Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ActiveIdWindowIsJustChanged, WantTextInputIsJustChanged #29

Conversation

sardananikolaevaskyboxlabs
Copy link

@sardananikolaevaskyboxlabs sardananikolaevaskyboxlabs commented Mar 21, 2024

Added ActiveIdWindowIsJustChanged, WantTextInputIsJustChanged

SKYBOXLABS\sardana.nikolaeva added 2 commits March 26, 2024 13:27
…s can hook their own internal file handling objects"

This reverts commit e1cff96.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worthwhile to create a separate PR for the undo of those commits

@sardananikolaevaskyboxlabs sardananikolaevaskyboxlabs changed the title Bug AB#1185718: ImGUI blocks text events to text fields in UI Added ActiveIdWindowIsJustChanged, WantTextInputIsJustChanged Apr 1, 2024
@@ -1460,6 +1443,7 @@ struct ImGuiContext
ImU64 ActiveIdUsingKeyInputMask; // Active widget will want to read those key inputs. When we grow the ImGuiKey enum we'll need to either to order the enum to make useful keys come first, either redesign this into e.g. a small array.
ImVec2 ActiveIdClickOffset; // Clicked offset from upper-left corner, if applicable (currently only set by ButtonBehavior)
ImGuiWindow* ActiveIdWindow;
bool ActiveIdWindowIsJustChanged;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment explaining what this is and how this is different from ActiveIdIsJustActivated?

@sardananikolaevaskyboxlabs sardananikolaevaskyboxlabs deleted the sardananikolaeva/1185718_ImGUI_blocks_text_events branch April 1, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants